[TaskExecutors] Add missing return type to _DefaultGlobalConcurrentExecutor.asUnownedTaskExecutor()
#71337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecutor.asUnownedTaskExecutor(). Addresses a warning that appears to point to a probable bug.
ktoso
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Oh boy that's a funny case...
We create this type for users to refer to but runtime does not utilize it explicitly.
We also have a default impl for the protocol requirement asUnownedTaskExecutor so this slipped through by accident huh.
Great catch, thank you -- yes this would be a bug when people try to use this executor reference explicitly
ktoso
added
the
concurrency
|
@swift-ci please smoke test |
tshortli
deleted the
global-concurrent-executor-as-unowned-task-executor-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a warning that appears to point to a probable bug.