BooleanLiteralFolding: remove dead blocks #71339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Great, thanks! Will check tomorrow on my testcases. |
Remove all dead blocks which are a result of constant folding condition branches
eeckstein
force-pushed
the
remove-dead-blocks
branch
from
ec4c4f9 to
6493872
Compare
|
@swift-ci test |
|
@kavon Can you please check if the change in the discard_checking testfile looks good? IMO it makes sense, because the |
|
This looks ok to me! Autodiff is more robust wrt unreachable blocks as in #71356 Though I'm not sure it covers 100% of cases :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all dead blocks which are a result of constant folding conditional branches