Sema: Fix problems with checkTypeWitness() #71354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
hborla,
xedin,
AnthonyLatsis,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro and
tshortli
as code owners
slavapestov
requested review from
kavon
and removed request for
xedin,
rintaro,
DougGregor,
bnbarham,
CodaFi,
ahoppen,
hamishknight and
tshortli
slavapestov
force-pushed
the
check-type-witness-fix
branch
from
a3747c1 to
f0159c9
Compare
Our tentative witness might have weird concrete DependentMemberTypes in it. In that case, perform a more relaxed check that can succeed as long as the witness is not completely invalid. This problem was exposed by existing test cases starting to fail once implicit Copyable requirements were introduced, because these concrete DependentMemberTypes do not conform to protocols. This now postpones the check until all witnesses have been fully substituted. This also fixes a long-standing bug with superclass requirements on associated types. Fixes swiftlang#48770, swiftlang#51772, rdar://95729075.
slavapestov
force-pushed
the
check-type-witness-fix
branch
from
f0159c9 to
477e057
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
This was referenced Feb 3, 2024
|
@slavapestov FYI you need to add the "fixes" et al. keyword before every issue reference in order for GitHub to recognize and link them all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up while running our existing tests with NoncopyableGenerics turned on, but it's an old issue and closely related to a problem with superclass requirements in protocols as well.
Fixes #48770, fixes #50561, fixes #50779, fixes #51772, fixes #53012, rdar://42012633, rdar://95729075.