Skip to content

[embedded] Print function name + class name when missing loc in 'non-final generic fuctions' diagnostic #71415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2024
Merged

[embedded] Print function name + class name when missing loc in 'non-final generic fuctions' diagnostic #71415

merged 1 commit into from
Feb 7, 2024

Conversation

kubamracek
Copy link
Contributor

Just adding a fallback in case we're missing source location when printing this diagnostic:

<unknown>:0: error: classes cannot have non-final generic fuctions in embedded Swift

@kubamracek kubamracek requested a review from eeckstein February 6, 2024 19:21
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek merged commit 802aab8 into swiftlang:main Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kubamracek