[TypeChecker] Adjust witness matching to strip concurrency from ObjC … #71493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
ktoso,
AnthonyLatsis,
hborla and
slavapestov
as code owners
|
@swift-ci please test |
ktoso
approved these changes
Feb 9, 2024
DougGregor
approved these changes
Feb 9, 2024
DougGregor
reviewed
Feb 9, 2024
…requirements `swift_attr` attributes in the type context were ignored before, which means that we need to maintain status quo to avoid breaking witness matching by stripping everything concurrency related from inner types. Resolves: rdar://122592751
… 6 without strict concurrency enabled
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…requirements
swift_attrattributes in the type context were ignored before,which means that we need to maintain status quo to avoid breaking
witness matching by stripping everything concurrency related from inner types.
Resolves: rdar://122592751