Teach the old associated type inference about AsyncSequence.Failure #71512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new one is smart enough to figure out a type witness for AsyncSequence.Failure from AsyncSequence.AsyncIterator.Failure, but the old one doesn't have general logic to handle cases like these. Introduce a bespoke rule to keep the old/new associated type inference logic in sync for the newly-introduced Failure type.
DougGregor
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new one is smart enough to figure out a type witness for
AsyncSequence.Failure from AsyncSequence.AsyncIterator.Failure, but the
old one doesn't have general logic to handle cases like these. Introduce
a bespoke rule to keep the old/new associated type inference logic in
sync for the newly-introduced Failure type.