Deserializer: better error message if types of referenced functions don't match #71612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
DougGregor
reviewed
Feb 14, 2024
| fnName = decl->getNameStr(); | ||
| } | ||
| fn->getModule().getASTContext().Diags.diagnose(fn->getLocation().getSourceLoc(), diag::deserialize_function_type_mismatch, fnName, fnType.getASTType(), type.getASTType()); | ||
| exit(1); |
There was a problem hiding this comment.
Is there something we can do other than exit?
There was a problem hiding this comment.
I didn't find anything better. We need to abort here immediately to not run into subsequent asserts/crashes.
I'm open to suggestions :-)
There was a problem hiding this comment.
Maybe llvm::report_fatal_error()?
There was a problem hiding this comment.
That also let it look like a compiler crash
slavapestov
reviewed
Feb 14, 2024
lib/Serialization/DeserializeSIL.cpp
Outdated
| if (auto *decl = dyn_cast_or_null<AbstractFunctionDecl>(dc->getAsDecl())) | ||
| fnName = decl->getNameStr(); | ||
| } | ||
| fn->getModule().getASTContext().Diags.diagnose(fn->getLocation().getSourceLoc(), diag::deserialize_function_type_mismatch, fnName, fnType.getASTType(), type.getASTType()); |
| fnName = decl->getNameStr(); | ||
| } | ||
| fn->getModule().getASTContext().Diags.diagnose(fn->getLocation().getSourceLoc(), diag::deserialize_function_type_mismatch, fnName, fnType.getASTType(), type.getASTType()); | ||
| exit(1); |
There was a problem hiding this comment.
Maybe llvm::report_fatal_error()?
…on't match So far this resulted in an assert (in best case). Now a readable error is printed.
eeckstein
force-pushed
the
function-type-mismatch-error
branch
from
f7b24bb to
232a244
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far this resulted in an assert (in best case). Now a readable error is printed.