Skip to content

[ConsumeAddrChecker] Check in_guaranteed arguments. #72257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[ConsumeAddrChecker] Check in_guaranteed arguments. #72257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/SILOptimizer/Mandatory/ConsumeOperatorCopyableAddressesChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2465,6 +2465,7 @@ class ConsumeOperatorCopyableAddressesCheckerPass
for (auto *arg : fn->front().getSILFunctionArguments()) {
if (arg->getType().isAddress() &&
(arg->hasConvention(SILArgumentConvention::Indirect_In) ||
arg->hasConvention(SILArgumentConvention::Indirect_In_Guaranteed) ||
arg->hasConvention(SILArgumentConvention::Indirect_Inout)))
addressesToCheck.insert(arg);
}
Expand Down
22 changes: 21 additions & 1 deletion test/SILOptimizer/consume_operator_kills_copyable_addressonly_lets.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public func conditionalBadConsumingUseLoop2<T>(_ x: T) {

// This is ok, no uses after.
public func simpleMoveOfParameter<T>(_ x: T) -> () {
let _ = consume x // expected-error {{'consume' applied to value that the compiler does not support}}
let _ = consume x
}

public func simpleMoveOfOwnedParameter<T>(_ x: __owned T) -> () {
Expand Down Expand Up @@ -202,6 +202,26 @@ public func errorLoopMoveOfParameterNonConsume<T>(_ x: __owned T) -> () { // exp
}
}

func consumeConsuming<T>(_ k: consuming T) {
_ = consume k
}

func consumeBorrowing<T>(_ k: borrowing T) { // expected-error{{'k' is borrowed and cannot be consumed}}
_ = consume k // expected-note{{consumed here}}
}

func consumeOwned<T>(_ k: __owned T) {
_ = consume k
}

func consumeShared<T>(_ k: __shared T) {
_ = consume k
}

func consumeBare<T>(_ k: T) {
_ = consume k
}

////////////////////////
// Pattern Match Lets //
////////////////////////
Expand Down