Skip to content

[DebugInfo] Fix crash on empty tuple fragments #72270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Snowy1803
Copy link
Member

Fixes a crash when we had a fragment of a tuple with no size (such as Void)

rdar://124408249

@Snowy1803 Snowy1803 force-pushed the fix-empty-tuple-fragments-crash branch 2 times, most recently from 1abfdc0 to 4a48eb4 Compare March 12, 2024 21:38
@Snowy1803
Copy link
Member Author

@swift-ci Please test source compatibility

@Snowy1803
Copy link
Member Author

@swift-ci Please smoke test

@Snowy1803 Snowy1803 force-pushed the fix-empty-tuple-fragments-crash branch from 4a48eb4 to 2e48ebd Compare March 13, 2024 00:35
@Snowy1803 Snowy1803 force-pushed the fix-empty-tuple-fragments-crash branch from 2e48ebd to ffb8ece Compare March 13, 2024 00:38
@Snowy1803
Copy link
Member Author

@swift-ci please smoke test

@Snowy1803
Copy link
Member Author

Snowy1803 commented Mar 13, 2024

@Snowy1803 Snowy1803 requested a review from adrian-prantl March 13, 2024 16:26
@adrian-prantl
Copy link
Contributor

FWIW, if you just address straightforward review comments and the PR is already accepted, I would just go ahead and merge it without requesting a re-review.

@Snowy1803 Snowy1803 merged commit 2ebae40 into swiftlang:main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants