ClangImporter: handle -target-cpu for x86 targets
#72603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test Windows platform |
|
Could you add a test case as well? |
|
@hyp there already are test cases for this (which is made obvious by the failure in the tests). |
|
@swift-ci please test Windows platform |
|
Hmm, that is surprising ... the clang importer tests didn't catch this change. I can try to add a test case I suppose. |
`-mcpu` is a deprecated "alias" (unsupported) on x86 targets for `-mtune`. Unlike `-mcpu`, `-mtune` simply tunes the code for the CPU but does not prevent execution on other targets. In order to match the behaviour of `-mcpu` on ARM, we must use both `-march=` and `-mtune=`. Adjust this behaviour to allow tuning of code for non-Darwin targets.
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
hyp
approved these changes
Apr 2, 2024
|
@swift-ci please test macOS platform |
1 similar comment
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-mcpuis a deprecated "alias" (unsupported) on x86 targets for-mtune. Unlike-mcpu,-mtunesimply tunes the code for the CPU but does not prevent execution on other targets. In order to match the behaviour of-mcpuon ARM, we must use both-march=and-mtune=. Adjust this behaviour to allow tuning of code for non-Darwin targets.