Skip to content

[CodeCompletion] Parse multiple catch clauses if the do body contains the code completion token #72976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Apr 11, 2024

  • Explanation: If a do statement’s body contained a code completion token, we would only parse a single catch clause for it, which would leave the second catch clause to be parsed as a standalone pattern without an initializer. Such a standalone pattern can cause type checking of closures to fail, resulting in no code completion results inside the do body.
  • Scope: Parsing of do statements with a code completion token in the do body and multiple catch clauses
  • Risk: Low, only affects code completion
  • Testing: Added test case
  • Issue: rdar://125303959
  • Reviewer: @rintaro and @hamishknight on [CodeCompletion] Parse multiple catch clauses if the do body contains the code completion token #72910

…ains the code completion token

rdar://125303959
@ahoppen ahoppen requested a review from a team as a code owner April 11, 2024 06:12
@ahoppen
Copy link
Member Author

ahoppen commented Apr 11, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 66e7c6a into swiftlang:release/6.0 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants