[cxx-interop] Import NonCopyable* as OpaquePointer if noncopyable generics are disabled
#73055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
egorzhdan
commented
Apr 16, 2024
lib/ClangImporter/ImportType.cpp
Outdated
| // If non-copyable generics are disabled, we cannot specify | ||
| // UnsafePointer<T> with a non-copyable type T. | ||
| if (pointeeType && pointeeType->isNoncopyable() && | ||
| !Impl.SwiftContext.LangOpts.hasFeature(Feature::NoncopyableGenerics)) |
There was a problem hiding this comment.
@lorentey do you know if this is the right way to check whether we can use UnsafePointer<NonCopyable>?
egorzhdan
force-pushed
the
egorzhdan/ncg-unsafepointer
branch
from
a18ed20 to
ec5162a
Compare
egorzhdan
changed the title
NonCopyable* as UnsafeRawPointer if noncopyable generics are disabledNonCopyable* as OpaquePointer if noncopyable generics are disabled
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
egorzhdan
force-pushed
the
egorzhdan/ncg-unsafepointer
branch
from
9c21f9b to
b0d845b
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
egorzhdan
force-pushed
the
egorzhdan/ncg-unsafepointer
branch
from
b0d845b to
fa25a5e
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
egorzhdan
force-pushed
the
egorzhdan/ncg-unsafepointer
branch
from
8493c7d to
d3ef25d
Compare
|
@swift-ci please test |
… generics are disabled C++ pointer type `T*` is generally imported as `Unsafe(Mutable)Pointer<T>`. However, if `T` is non-copyable in Swift (e.g. it has a deleted C++ copy constructor), using `UnsafePointer<T>` type requires noncopyable generics to be enabled. This was causing assertion failures when building SwiftCompilerSources in #72912.
…T` when adding base member accessors
egorzhdan
force-pushed
the
egorzhdan/ncg-unsafepointer
branch
from
d3ef25d to
6140ba1
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ pointer type
T*is generally imported asUnsafe(Mutable)Pointer<T>. However, ifTis non-copyable in Swift (e.g. it has a deleted C++ copy constructor), usingUnsafePointer<T>type requires noncopyable generics to be enabled.This was causing assertion failures when building SwiftCompilerSources in #72912.