Skip to content

Allow AddressUseDefWalker to continue past MarkUninitializedInst #73621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2024

Conversation

atrick
Copy link
Contributor

@atrick atrick commented May 14, 2024

Also adds test infrastructure to match the C++ tests so we can guarantee consistency across code bases.

atrick added 4 commits May 14, 2024 10:31
Add a unit test harness to SwiftCompilerSources to match the one in C++ since
both source bases have different implementations of the same utilities, and they
must be consistent for correctness.
If was called accesspath-base, but it's primarily about the uses of the accesspath, not the base. Very confusing.
This makes SwiftCompilerSources address/access utilities consistent with C++ and
allows them to be used in diagnostic passes.
@atrick atrick requested a review from eeckstein as a code owner May 14, 2024 17:58
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atrick
Copy link
Contributor Author

atrick commented May 14, 2024

@swift-ci test

@atrick
Copy link
Contributor Author

atrick commented May 22, 2024

@swift-ci smoke test

@atrick atrick enabled auto-merge May 22, 2024 20:55
@atrick
Copy link
Contributor Author

atrick commented May 22, 2024

@swift-ci test

@atrick
Copy link
Contributor Author

atrick commented May 22, 2024

@swift-ci test source compatibility

@atrick atrick merged commit b88566a into swiftlang:main May 23, 2024
@atrick atrick deleted the fix-access-mark-uninit branch May 23, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants