Various fixes for @preconcurrency
#73698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f non-Sendable types
…es in deinit Instance properties of non-sendable types cannot safely be accessed within deinitializers. Make sure we respect `@preconcurrency` when diagnosing these.
When determining whether a non-sendable type is a nominal type that is affected by `@preconcurrency`, be sure to look at the specific type even when it's part of larger type, e.g., the `NS` in `NS?`. This makes `@preconcurrency` work properly through structural types like arrays, optionals, and dictionaries. While here, also check whether the nominal declaration itself has been marked as `@preconcurrency`. Fixes rdar://125081249.
DougGregor
requested review from
ktoso,
hborla,
slavapestov,
xedin and
kavon
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audit the places where we do
Sendablechecking to ensure that they handle@preconcurrencyappropriately, and fix several issues:@Sendablemethods on a non-SendabletypeSendablenonisolated letSendableinstance properties of an actor-isolated type within the deinitializerMoreover, make sure that we correctly check for
@preconcurrencyfor the actual non-Sendable nominal types that occur within a larger type expression, e.g., theNSinNS?rather than only looking at the outer optional. This makes@preconcurrencywork properly for arrays, optionals, sets, etc. of non-Sendabletypes. Fixes rdar://125081249