[Test] Remove -disable-sil-ownership-verifier use. #74051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag had been used in test/SILOptimizer/definite_init_inout_super_init.swift because SILGen generated invalid SIL which would only be diagnosed during DI. Thanks to swiftlang#73664 , this is diagnosed before SILGen. One other test case use (test/PrintAsObjC/extensions.swift) remains.
|
@swift-ci please test |
|
If #73664 is reverted, then do we still want to merge this? |
|
Sadly no (why automerge is disabled). |
|
@swift-ci please test macos platform |
It was only reverted on 6.0 and not main. |
|
Yep, that's why this is still open. |
|
There won't be a revert thanks to #74133 . |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag had been used in
test/SILOptimizer/definite_init_inout_super_init.swiftbecause SILGen generated invalid SIL which would only be diagnosed during DI. Thanks to #73664 , this is diagnosed before SILGen.One other test case use (
test/PrintAsObjC/extensions.swift) remains.