Skip to content

Fix SILCombine to delete dead end_access instructions. #74073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jun 1, 2024

Otherwise, the SILVerifier will raise an error.

Fixes rdar://121599876 (SILCombine should delete instructions in blocks dominated by cond_fail -1)

Otherwise, the SILVerifier will raise an error.

Fixes rdar://121599876 (SILCombine should delete instructions in
blocks dominated by cond_fail -1)
@atrick atrick requested a review from nate-chandler June 1, 2024 06:11
@atrick
Copy link
Contributor Author

atrick commented Jun 1, 2024

@swift-ci test

Copy link
Contributor

@nate-chandler nate-chandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atrick atrick merged commit a031884 into swiftlang:main Jun 1, 2024
@atrick atrick deleted the fix-silcombine-dead-code branch June 1, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants