[6.0🍒] NCGenerics: improve diagnostics #74148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kavon
commented
Jun 5, 2024
kavon
commented
- Explanation: Changes diagnostics by deleting old, ad-hoc ones in favor of allowing the regular diagnosis logic in the constraint solver diagnose things instead. Does add one new, simple note.
- Scope: Important for understanding why you can't call a method in a Copyable-constrained extension of a type.
- Issue: rdar://127369509
- Original PR: NCGenerics: improve diagnostics #73927
- Risk: Low, it's a diagnostics-focused change.
- Testing: included.
- Reviewer: @xedin & @jckarter
Removing the old, ad-hoc diagnostics code improves the diagnostics we emit, since the existing diagnostics for missing conformances is already pretty good. rdar://127369509 (cherry picked from commit c9cfe28)
resolves the assertion failure in rdar://125196271 but not the underlying issue. (cherry picked from commit 8090e39)
|
@swift-ci test |
|
@swift-ci test |
tbkka
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.