[6.0][Concurrency] CaseIterable synthesized allCases must be nonisolated #74255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
a team,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
rintaro,
hamishknight,
shahmishal,
mikeash,
al45tair,
compnerd,
adrian-prantl,
AnthonyLatsis,
QuietMisdreavus,
kavon,
artemcm,
CodaFi,
DougGregor,
zoecarver,
hyp,
egorzhdan,
MaxDesiatov,
etcwilde,
phausler,
tshortli,
beccadax,
ian-twilightcoder and
eeckstein
as code owners
ktoso
removed request for
phausler,
mikeash,
etcwilde,
hyp,
beccadax,
bnbarham,
CodaFi,
adrian-prantl,
shahmishal,
al45tair,
egorzhdan,
ahoppen,
QuietMisdreavus,
artemcm,
zoecarver,
ian-twilightcoder,
eeckstein,
tshortli,
AnthonyLatsis and
hamishknight
ktoso
force-pushed
the
pick-wip-caseiterable-nonisolated
branch
from
1912c2e to
a4bf8ac
Compare
|
@swift-ci please test |
ktoso
changed the title
ktoso
changed the title
DougGregor
approved these changes
Jun 10, 2024
ktoso
force-pushed
the
pick-wip-caseiterable-nonisolated
branch
from
a4bf8ac to
5c5acac
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: allCases synthesized by CaseIterable should be
nonisolated, as otherwise it'll conflict in isolation with global actor isolated enums.Scope/Impact: Global actor isolated enums with
CaseIterabletoday don't compileRisk: Low, adds nonisolated to
allCasesTesting: CI testing
Reviewed by: @DougGregor
Original PR: #74254
Radar: rdar://127968265