Skip to content

[embedded] Enable read-only static array promotion in embedded mode #74551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2024
Merged

[embedded] Enable read-only static array promotion in embedded mode #74551

merged 1 commit into from
Jun 20, 2024

Conversation

kubamracek
Copy link
Contributor

Fixes #74549.

@kubamracek kubamracek requested a review from eeckstein June 19, 2024 16:16
@kubamracek kubamracek added the embedded Embedded Swift label Jun 19, 2024
eeckstein
eeckstein approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek enabled auto-merge June 20, 2024 03:45
@kubamracek kubamracek merged commit 70c54bb into swiftlang:main Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

Assignees
No one assigned
Labels
embedded Embedded Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixed-size, constant, global array of Ints not promoted to StaticArray storage on some targets
2 participants
@kubamracek @eeckstein