[Concurrency] Remove the global actor check when allowing 'nonisolated' on mutable Sendable storage. #75084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
simanerush
force-pushed
the
sima/131339439
branch
from
248b252 to
a7f3c2d
Compare
|
@swift-ci please smoke test |
…d' on mutable Sendable storage.
simanerush
force-pushed
the
sima/131339439
branch
from
a7f3c2d to
e0a128f
Compare
|
@swift-ci please smoke test |
xedin
approved these changes
Jul 9, 2024
Comment on lines
-7011
to
+7014
| if (dc->isTypeContext()) { | ||
| if (auto nominal = dc->getSelfStructDecl()) { | ||
| if (!var->isStatic() && type->isSendableType() && | ||
| getActorIsolation(nominal).isGlobalActor()) { | ||
| canBeNonisolated = true; | ||
| } | ||
| if (auto nominal = dc->getSelfStructDecl()) { | ||
| if (nominal->getDeclaredTypeInContext()->isSendableType() && | ||
| !var->isStatic() && type->isSendableType()) { | ||
| canBeNonisolated = true; |
There was a problem hiding this comment.
Why was the global actor check redundant? It is not so according to the proposal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global actor check was redundant, so remove it. Added more tests to the testing suite to verify that
nonisolatedis allowed on implicitly Sendable structs.Also make sure that on non-Sendable structs,
nonisolatedis still not allowed on any mutable storageResolves rdar://131339439.