[Runtime][Win32] Fix fatalError() backtraces. #75108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were calling `SymInitialize()` multiple times, which is wrong, which was making the `SymbolInfo::lookup()` call fail. Also, we weren't fetching the module names, so we should do that too. rdar://130992923
|
@swift-ci Please smoke test |
grynspan
reviewed
Jul 9, 2024
grynspan
reviewed
Jul 9, 2024
grynspan
reviewed
Jul 9, 2024
grynspan
reviewed
Jul 9, 2024
compnerd
reviewed
Jul 9, 2024
Prefer `ZeroMemory()` to `::memset()` here. Use `sizeof(*wszBuffer)` instead of `sizeof(WCHAR)`, just in case. Don't use `*this=other`, because that motivates tests around `::free()`, but instead pull the shared code out into some private functions. Also, fix `SymbolInfo()` to initialize the pointer members. rdar://130992923
al45tair
force-pushed
the
eng/PR-130992923
branch
from
f2195eb to
418a240
Compare
|
@swift-ci Please smoke test |
compnerd
approved these changes
Jul 10, 2024
Fix an unused variable warning in `Errors.cpp`. Use brace initialization syntax in `SymbolInfo.cpp` rather than using a constructor call. rdar://130992923
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calling
SymInitialize()multiple times, which is wrong, which was making theSymbolInfo::lookup()call fail. Also, we weren't fetching the module names, so we should do that too.rdar://130992923