Skip to content

[6.0][Basic] Don't rewrite source buffer copy multiple times #75118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

[6.0][Basic] Don't rewrite source buffer copy multiple times #75118

merged 1 commit into from
Jul 10, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jul 9, 2024 •
edited
Loading

Cherry-pick #75115 into release/6.0

  • Explanation: When writing out a macro-synthesized buffer to the file system, the file name is supposed to be recorded in the source manager. Previously however, the logic setting the file name was updating the copy of the information, not the actual information in the source manager. This change fixes that issue by returning the pointer to the information instead of the copy.
  • Scope: Macros
  • Risk: Low. Other places using the function should keep working.
  • Testing: Passes current test suite. No test update because there's no "visible" behavior change.
  • Issues: rdar://130478685
  • Reviewer: Ben Barham (@bnbarham), Doug Gregor (@DougGregor)

@rintaro
[Basic] Don't rewrite source buffer copy multiple times
78e14a4 
The on-disc buffer file name was not recorded correctly.

rdar://130478685
(cherry picked from commit 90c2975)
@rintaro rintaro requested a review from a team as a code owner July 9, 2024 22:29
@rintaro
Copy link
Member Author

rintaro commented Jul 9, 2024

@swift-ci Please test

@rintaro rintaro enabled auto-merge July 9, 2024 22:44
@rintaro rintaro merged commit ee010a9 into swiftlang:release/6.0 Jul 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @DougGregor