[region-isolation] Make "unknown pattern error" always an error. #75137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows an actual issue with the compiler where semantically we should crash. Rather than crashing (due to the broken invariants), we emit this error so that the user gets a nice error message at the problem place and can work around it instead of just getting a mysterious crash. Previously, we were making this a warning in swift 5 mode... but given the issues, it makes sense to emit an error diagnostic so we get the feedback and the user cannot ship the code. rdar://131482934
|
@swift-ci smoke test |
hborla
approved these changes
Jul 10, 2024
|
@swift-ci test source compatibility |
|
Btw for anyone listening in... both source compat runs passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows an actual issue with the compiler where semantically we should crash. Rather than crashing (due to the broken invariants), we emit this error so that the user gets a nice error message at the problem place and can work around it instead of just getting a mysterious crash.
Previously, we were making this a warning in swift 5 mode... but given the issues, it makes sense to emit an error diagnostic so we get the feedback and the user cannot ship the code.
rdar://131482934