[Macros] Narrow the carve-out for DebugDescription’s use of symbol linkage markers. #75323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
requested review from
slavapestov,
xedin,
artemcm and
tshortli
as code owners
|
@swift-ci please smoke test |
kastiglione
reviewed
Jul 18, 2024
| macroDecl->getName().getBaseIdentifier() | ||
| .str().equals("_DebugDescriptionProperty")) | ||
| return true; | ||
| } |
There was a problem hiding this comment.
There's a missing return false at the end. It may not be an issue in practice.
There was a problem hiding this comment.
Good catch, thank you! Really wish that was an error in C++ :) I'll put up a follow up to fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only allows symbol linkage markers in the peer expansion of
_DebugDescriptionProperty.