🍒 [6.0][cxx-interop] Fix input header paths in a test #75326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation: There is a difference between the logic resolving modules in upstream and downstream versions of the compiler this is why the wrong path did not fail the CIs upstream. Having the correct path both fixes downstream CIs and makes the tests more resilient to changes in the lookup logic in the future. Scope: Tests. Risk: Low, test change only to fix CI. Testing: No additional tests needed. Issue: rdar://131629163 Reviewer: @egorzhdan Original PR: #75237
|
@swift-ci please test |
Xazax-hun
added
c++ interop
Xazax-hun
changed the title
DougGregor
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: There is a difference between the logic resolving modules in upstream and downstream versions of the compiler this is why the wrong path did not fail the CIs upstream. Having the correct path both fixes downstream CIs and makes the tests more resilient to changes in the lookup logic in the future.
Scope: Tests.
Risk: Low, test change only to fix CI.
Testing: No additional tests needed.
Issue: rdar://131629163
Reviewer: @egorzhdan
Original PR: #75237