[6.0] Downgrade the error about #isolation in @_unsafeInheritExecutor when the concurrency library is old
#75348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen the concurrency library is old The introduction of the error concerning use of `#isolation` within an `@_unsafeInheritExecutor` function was carefully staged between the concurrency library and compiler to avoid breaking source compatibility. However, it is a source compatibility break when dealing certain revisions of the concurrency library that adopted `#isolation` prior to the compiler error. Detect when the _Concurrency library doesn't have the necessary workarounds in it and downgrade the error to a warning. Fixes rdar://132023573.
|
@swift-ci please test |
hborla
approved these changes
Jul 18, 2024
ktoso
approved these changes
Jul 18, 2024
|
@swift-ci please test macOS |
DougGregor
deleted the
isolation-in-unsafe-inherit-downgrade-old-concurrency-lib-6.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#isolationwithin an@_unsafeInheritExecutorfunction was carefully staged between the concurrency library and compiler to avoid breaking source compatibility. However, it is a source compatibility break when dealing certain revisions of the concurrency library that adopted#isolationprior to the compiler error. Detect when the _Concurrency library doesn't have the necessary workarounds in it and downgrade the error to a warning.@_unsafeInheritExecutorfunctions.#isolationin@_unsafeInheritExecutorwhen the concurrency library is old #75347