Small Noncopyable Fixes, pt 1 #75410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicit initializers internally have "Default" parameter ownership specifiers, which can only happen for a noncopyable type if the decl is synthesized, since ownership is required to be specified if it were written in the source. There's no reason to warn for such decls, since the user can't see it anyway. So specifically target an explicitly written "borrowing" as being confusing, since that's the only valid case that could happen anyway. resolves rdar://131546153
We don't yet have keypaths working correctly to allow access to noncopyable fields, so we should raise a friendly error in Sema rather than an error-out elsewhere vaguely. resolves rdar://109287447
|
@swift-ci test |
rdar://106164128
kavon
requested review from
xymus,
eeckstein,
jckarter,
rjmccall and
ktoso
as code owners
|
@swift-ci test source compatability |
|
@swift-ci smoke test |
This hidden attribute is a leftover from before the '~Copyable' syntax. rdar://130526083
kavon
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
|
@swift-ci smoke test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit for details.
resolves rdar://131546153&109287447&106164128&130526083