[Sema/SourceKit] Emit same diagnostics for missing protocol requirements on the command line and in SourceKit #75667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
AnthonyLatsis,
hborla,
slavapestov,
bnbarham,
hamishknight,
rintaro,
kavon,
xedin and
ktoso
as code owners
ahoppen
force-pushed
the
build-issues-live-issues
branch
from
928043b to
564a3b6
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
build-issues-live-issues
branch
from
564a3b6 to
6d879cf
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
build-issues-live-issues
branch
from
6d879cf to
6577a60
Compare
ahoppen
requested review from
a team,
CodaFi,
DougGregor,
zoecarver,
hyp and
egorzhdan
as code owners
|
@swift-ci Please smoke test |
DougGregor
reviewed
Aug 7, 2024
| @@ -3474,11 +3474,6 @@ bool ContextualFailure::tryProtocolConformanceFixIt( | |||
| conformanceDiag.fixItInsert(nameEndLoc, ": " + protoString); | |||
| } | |||
|
|
|||
| // Emit fix-its to insert requirement stubs if we're in editor mode. | |||
| if (!getASTContext().LangOpts.DiagnosticsEditorMode) { | |||
There was a problem hiding this comment.
Can we fully remove this LangOpt?
There was a problem hiding this comment.
There are two more uses (about switch IIRC) that I want to remove in a follow-up PR. This one is big enough on its own.
DougGregor
approved these changes
Aug 7, 2024
xedin
approved these changes
Aug 7, 2024
bnbarham
approved these changes
Aug 7, 2024
…nts on the command line and in SourceKit Some editors use diagnostics from SourceKit to replace build issues. This causes issues if the diagnostics from SourceKit are formatted differently than the build issues. Make sure they are rendered the same way, removing most uses of `DiagnosticsEditorMode`. To do so, always emit the `add stubs for conformance` note (which previously was only emitted in editor mode) and remove all `; add <something>` suffixes from notes that state which requirements are missing. rdar://129283608
ahoppen
force-pushed
the
build-issues-live-issues
branch
from
6577a60 to
6610439
Compare
|
@swift-ci Please smoke test |
asl
reviewed
Aug 8, 2024
| @@ -3,12 +3,11 @@ | |||
| // FIXME: this test only passes on platforms which have Float80. | |||
| // <rdar://problem/19508460> Floating point enum raw values are not portable | |||
|
|
|||
| // REQUIRES: CPU=i386 || CPU=x86_64 | |||
There was a problem hiding this comment.
The test fails on arm platforms due to this change. See FIXME above.
There was a problem hiding this comment.
Already fixing it in #75784. This change as unintentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some editors use diagnostics from SourceKit to replace build issues. This causes issues if the diagnostics from SourceKit are formatted differently than the build issues. Make sure they are rendered the same way, removing most uses of
DiagnosticsEditorMode.To do so, always emit the
add stubs for conformancenote (which previously was only emitted in editor mode) and remove all; add <something>suffixes from notes that state which requirements are missing.rdar://129283608