Sema: Relax availability of typealiases for inferred type witness #76066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
a team,
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
tshortli
force-pushed
the
associated-type-inference-availability
branch
from
65ff6ac to
e57bf14
Compare
|
@swift-ci please smoke test |
Only constrain the availability of the synthesized typealias for an inferred
type witness by the availability of the associated type if the associated type
is less available than its protocol. Without this, source compatibility is
broken for some conformances. For example:
```
struct IdentifiableValue: Identifiable {
let id = 42
}
extension IdentifiableValue {
// error: 'ID' is only available in macOS 10.15 or newer
var nextID: ID {
return id + 1
}
}
```
Fixes a regression introduced by swiftlang#71496.
Resolves rdar://134584323
tshortli
force-pushed
the
associated-type-inference-availability
branch
from
e57bf14 to
1c9b6eb
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only constrain the availability of the synthesized typealias for an inferred type witness by the availability of the associated type if the associated type is less available than its protocol. Without this, source compatibility is broken for some conformances. For example:
Fixes a regression introduced by #71496.
Resolves rdar://134584323