Frontend: For whole module compiles, omit filelists from stack dumps #76096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For batch compile jobs, it's helpful to see which files are considered primary and that was the original reason why filelist contents were printed in compiler crash stack dumps. However, for whole module compile jobs, the contents of the filelist is uninteresting (it's just all the files in the module) and can be hundreds or thousands of lines long so it often causes important information to be trimmed from stack dumps received in reproducers.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For batch compile jobs, it's helpful to see which files are considered primary and that was the original reason why filelist contents were printed in compiler crash stack dumps. However, for whole module compile jobs, the contents of the filelist is uninteresting (it's just all the files in the module) and can be hundreds or thousands of lines long so it often causes important information to be trimmed from stack dumps received in reproducers.