[stdlib] Fix a manual lifetime. #76098
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the stdlib has manual lifetimes, the lifetime of `base2` here must be guarded not to be shrunk through any operations that read pointers. rdar://133969821
|
@swift-ci please test |
|
@swift-ci please apple silicon benchmark |
|
@swift-ci please test source compatibility |
mikeash
reviewed
Aug 27, 2024
| switch value { | ||
| case .struct(let offset): | ||
| var base2 = base | ||
| defer { _fixLifetime(base2) } |
There was a problem hiding this comment.
I'm worried this issue might be lurking elsewhere too. Could we instead put the _fixLifetime in the implementation of withUnsafeBytes to ensure all uses have the pointee's lifetime extended to cover the closure?
|
Closing in favor of #76114 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the stdlib has manual lifetimes, the lifetime of
base2here must be guarded not to be shrunk through any operations that read pointers.rdar://133969821