Revert "Isolated synchronous deinit" #76237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight,
rintaro,
a team,
xymus,
kavon,
jckarter,
ktoso,
rjmccall,
hborla,
xedin,
slavapestov,
eeckstein,
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder,
CodaFi,
tshortli and
DougGregor
as code owners
|
@swift-ci Please smoke test |
ktoso
approved these changes
Sep 4, 2024
|
LGTM, unfortunate... The contributor will be offline for a few weeks so I'll see if I can manage to land this again. |
|
Actually, new idea -- we'll gate this with an experimental flag instead. Please don't revert. I'll put up the flag so we don't have to keep rebasing the work |
ktoso
requested changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #60057
This PR is causing quite a few tests to fail, so let’s revert it for now.
CC @ktoso