[wasm] Merge all wasi-sysroot into a single sysroot directory #76544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change merges all wasi-sysroot directories into a single sysroot directory to reuse header files across `wasm32-wasi` and `wasm32-wasip1-threads`.
|
@swift-ci smoke test |
MaxDesiatov
approved these changes
Sep 18, 2024
MaxDesiatov
added
WebAssembly
|
@swift-ci test linux |
|
@swift-ci build toolchain |
|
@swift-ci test |
|
@swift-ci build toolchain |
|
@swift-ci test linux |
|
It's not something flaky but the change includes something wrong. I need to debug it |
|
@swift-ci test linux |
|
Closing for now as this cannot be practically accomplished without fixing swiftlang/swift-package-manager#7973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change merges all wasi-sysroot directories into a single sysroot directory to reuse header files across
wasm32-wasiandwasm32-wasip1-threads. The resulted sysroot layout aligns with the layout in wasi-sdk distribution.