Remove symbols that are no longer part of ABI #76854
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please build toolchain macOS |
Originally added in swiftlang#73242. swiftlang#76826 was up to remove them but we took swiftlang#76824 instead. Resolves rdar://136918801.
bnbarham
force-pushed
the
actually-fix-abi-tests
branch
from
030298c to
cee41ef
Compare
|
@swift-ci please test |
|
@swift-ci please build toolchain macOS |
|
I think for a build with asserts, the additional symbols need to be removed only from abi test that does not have |
That was the intention here - I apparently checked out the wrong file when I was fixing it up though 😅. Thanks for merging yours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally added in #73242. #76826 was up to remove them but we took #76824 instead.
Resolves rdar://136918801.