[MoveAddrChecker] Look through mark_dependence to determine whether an address is initialized to begin with. #77143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the FIXME to derive whether an address begins initialized requires auditing all sites where the instruction is emitted to begin with, making this a predicate that depends only on the instruction can be done now.
To enable changing its definition.
Extend the hack to determine whether an address begins initialized to look through mark_dependence instructions.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
|
@swift-ci please test macos platform |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the hack to determine whether an address starts out initialized into a separate function and then extend it to look through
mark_dependenceinstructions.Fixes a bug with nested accessors.