[cxx-interop] Support conditional escapability #77588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
DougGregor
approved these changes
Nov 14, 2024
Xazax-hun
commented
Nov 14, 2024
| @@ -37,6 +37,30 @@ View g(int* x) { | |||
| return View(x); | |||
| } | |||
|
|
|||
| template<typename F, typename S> | |||
| struct SWIFT_ESCAPABLE_IF(F, S) MyPair { | |||
There was a problem hiding this comment.
We do not support nested templates yet. I plan to do that in a follow-up PR.
egorzhdan
approved these changes
Nov 15, 2024
This PR adds a variadic macro that builds a SwiftAttr string containing the names of the template type parameters that need to be escapable for the type to be considered escapable. It also adds logic to interpret this annotation. rdar://139065437
Xazax-hun
force-pushed
the
gaborh/conditional-escapability
branch
from
585396b to
558380f
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a variadic macro that builds a SwiftAttr string containing the names of the template type parameters that need to be escapable for the type to be considered escapable. It also adds logic to interpret this annotation.
rdar://139065437