Skip to content

swift-frontend: Driver support for SamplePGO #78078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2024
Merged

swift-frontend: Driver support for SamplePGO #78078

merged 3 commits into from
Dec 16, 2024

Conversation

kavon
Copy link
Member

@kavon kavon commented Dec 10, 2024

kavon added 2 commits December 12, 2024 17:42
@kavon
Options: update profile-sample-use flags for new driver
fbb8b9e 
- Don't use CommaJoined, since profile-sample-use only takes one file
- Specify that the flag is only supported by the new swift-driver.

for rdar://135443278
@kavon
Update test to cover use of flags from new driver
5cbe247
@kavon kavon force-pushed the samplepgo-driver-support branch from 3c7db5e to 5cbe247 Compare December 13, 2024 01:42
@kavon
Copy link
Member Author

kavon commented Dec 13, 2024

swiftlang/swift-driver#1753
@swift-ci smoke test

@kavon kavon marked this pull request as ready for review December 13, 2024 01:45
@kavon
Copy link
Member Author

kavon commented Dec 13, 2024 

# .---command stderr------------
# | <unknown>:0: warning: using (deprecated) legacy driver, Swift installation does not contain swift-driver at: 'C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\build\5\bin\swift-driver-new.exe'
# | <unknown>:0: warning: option '-profile-sample-use=' is only supported in swift-driver
# | Swift version 6.2-dev (LLVM be8c96d78337932, Swift 4a2d2cbd246f0d5)
# | Target: x86_64-unknown-windows-msvc
# | "C:\\Users\\swift-ci\\jenkins\\workspace\\swift-PR-windows\\build\\5\\bin\\swiftc.exe" -frontend -emit-ir -primary-file "T:\\5\\tools\\swift\\test-windows-x86_64\\Profiler\\Output\\samplepgo.swift.tmp/program.swift" -target x86_64-unknown-windows-msvc -disable-objc-interop -vfsoverlay "T:/5/tools/swift\\stdlib\\windows-vfs-overlay.yaml" -module-cache-path "T:\\5\\swift-test-results\\x86_64-unknown-windows-msvc\\clang-module-cache" -O -define-availability "SwiftStdlib 9999:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999" -define-availability "SwiftStdlib 5.0:macOS 10.14.4, iOS 12.2, watchOS 5.2, tvOS 12.2" -define-availability "SwiftStdlib 5.1:macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0" -define-availability "SwiftStdlib 5.2:macOS 10.15.4, iOS 13.4, watchOS 6.2, tvOS 13.4" -define-availability "SwiftStdlib 5.3:macOS 11.0, iOS 14.0, watchOS 7.0, tvOS 14.0" -define-availability "SwiftStdlib 5.4:macOS 11.3, iOS 14.5, watchOS 7.4, tvOS 14.5" -define-availability "SwiftStdlib 5.5:macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0" -define-availability "SwiftStdlib 5.6:macOS 12.3, iOS 15.4, watchOS 8.5, tvOS 15.4" -define-availability "SwiftStdlib 5.7:macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0" -define-availability "SwiftStdlib 5.8:macOS 13.3, iOS 16.4, watchOS 9.4, tvOS 16.4" -define-availability "SwiftStdlib 5.9:macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0" -define-availability "SwiftStdlib 5.10:macOS 14.4, iOS 17.4, watchOS 10.4, tvOS 17.4, visionOS 1.1" -define-availability "SwiftStdlib 6.0:macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0" -define-availability "SwiftStdlib 6.1:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, visionOS 9999" -in-process-plugin-server-path "C:\\Users\\swift-ci\\jenkins\\workspace\\swift-PR-windows\\build\\5\\bin\\SwiftInProcPluginServer.dll" -plugin-path "C:\\Users\\swift-ci\\jenkins\\workspace\\swift-PR-windows\\build\\5\\bin" -Xcc -Xclang -Xcc -fbuiltin-headers-in-system-modules -autolink-library oldnames -autolink-library msvcrt -Xcc -D_MT -Xcc -D_DLL -module-name test -o "T:\\5\\tools\\swift\\test-windows-x86_64\\Profiler\\Output\\samplepgo.swift.tmp/has-data.ll"
# `-----------------------------

Looks like the new swift driver isn't used on Windows?

@kavon
Copy link
Member Author

kavon commented Dec 13, 2024

swiftlang/swift-driver#1753
@swift-ci smoke test

@kavon kavon merged commit b633c81 into swiftlang:main Dec 16, 2024
3 checks passed
@kavon kavon deleted the samplepgo-driver-support branch December 16, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen Awaiting requested review from ahoppen

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kavon