[Sema] Highlight angle brackets <…> in diagnostics #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide fixit hints for ungeneric but specialized types (e.g. Int<Float>). Solves FIXME
Highlight the angle brackets on under- and overspecialized types. (E.g. Array<Int, Float> and Dictionary<Int>) Solves FIXME
| MutableArrayRef<TypeLoc> genericArgs, | ||
| bool isGenericSignature, | ||
| GenericTypeResolver *resolver); | ||
| Type applyUnboundGenericArguments(UnboundGenericType *unbound, |
There was a problem hiding this comment.
Is it ok to pass an UnboundGenericType or should it be wrapped inside a Type value?
With the previous commit the emitted diagnostics couldn't be easily emitted through the public API. This commit solves this problem by providing two different versions of `applyGenericArguments`, one emitting diagnostics, the other expecting valid parameters.
|
@DougGregor would you mind taking a look? |
| bool isGenericSignature, | ||
| GenericTypeResolver *resolver); | ||
|
|
||
| /// Apply generic arguments to the given type. | ||
| /// | ||
| /// This functions requires a valid unbound generic type with the correct |
JaSpa
force-pushed
the
highlight-generic-args
branch
from
b0e075d to
7822c92
Compare
|
I'd usually grumble about trailing whitespace changes, but it's fine; we should clean those up anyway. Thanks! |
|
Oh, I suspect this means that Sema could properly distinguish between "X<>" and "X" now, perhaps with some minor parser tweaks. |
DougGregor
added a commit
that referenced
this pull request
Jan 12, 2016
[Sema] Highlight angle brackets <…> in diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the checks for invalid generic arguments into
applyGenericTypeReprArgsso we can pass theGenericIdentTypeReprinto it to access the angle bracket range whileresolveDictionaryTypecan still useapplyUnboundGenericArgumentswithout anGenericIdentTypeRepr.Edit:
check-swiftpassed