Skip to content

IRGen: adjust code for MSVC warning C4468 (NFCI) #78583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

IRGen: adjust code for MSVC warning C4468 (NFCI) #78583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions lib/IRGen/IRGenSIL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2146,12 +2146,11 @@ static void emitEntryPointArgumentsNativeCC(IRGenSILFunction &IGF,
case SILCoroutineKind::None:
break;
case SILCoroutineKind::YieldOnce2:
if (IGF.IGM.IRGen.Opts.EmitYieldOnce2AsYieldOnce) {
LLVM_FALLTHROUGH;
} else {
if (!IGF.IGM.IRGen.Opts.EmitYieldOnce2AsYieldOnce) {
emitYieldOnce2CoroutineEntry(IGF, funcTy, *emission);
break;
}
LLVM_FALLTHROUGH;
case SILCoroutineKind::YieldOnce:
emitYieldOnceCoroutineEntry(IGF, funcTy, *emission);
break;
Expand Down Expand Up @@ -3866,12 +3865,10 @@ void IRGenSILFunction::visitFullApplySite(FullApplySite site) {
break;

case SILCoroutineKind::YieldOnce2:
if (IGM.IRGen.Opts.EmitYieldOnce2AsYieldOnce) {
LLVM_FALLTHROUGH;
} else {
// @yield_once_2 coroutines allocate in the callee
// @yield_once_2 coroutines allocate in the callee
if (!IGM.IRGen.Opts.EmitYieldOnce2AsYieldOnce)
break;
}
LLVM_FALLTHROUGH;

case SILCoroutineKind::YieldOnce:
coroutineBuffer = emitAllocYieldOnceCoroutineBuffer(*this);
Expand Down