[Backtracing] Support redirection to a named file. #79049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to specify a filename or directory name as the output-to setting in `SWIFT_BACKTRACE`. If the option is set to a directory name, generate a unique filename in that directory using the process name, process ID and timestamp. rdar://136977833
Mike rightly points out that it's possible for `open()` to fail with `EINTR`, which we should handle here. rdar://136977833
al45tair
added
🍒 release cherry pick
|
Explanation: Adds support for redirection of crash logs to a named file or to a directory. |
|
@swift-ci Please test |
|
(I've got another changeset to add to this — some security hardening that I think is worthwhile. Just testing it now.) |
We should harden the output path setting so that it can't be used as part of an exploit to get a crashing process to overwrite a file at an attacker-controller path, or to divert the crash report to `/dev/null` to hide their tracks or other such undesirable activity. Take a copy of the setting at start-up and write-protect it to prevent attackers overwriting it. Note that we already protect against attempts to trigger the backtracer from privileged programs (both on Darwin and Linux); this is really a belt and braces measure to make life harder for attackers. rdar://136977833
|
@swift-ci Please test |
ktoso
reviewed
Feb 12, 2025
ktoso
approved these changes
Feb 12, 2025
airspeedswift
previously approved these changes
Mar 20, 2025
airspeedswift
dismissed
their stale review
Missed there was an unaddressed issue
It looks like we aren't actually using it, so let's just delete it. rdar://136977833
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@swift-ci Please test macOS platform |
|
Yes please, would love to have this for swift-java work when we crash sometimes and the outputs get jumbled together with java's crash :-) |
airspeedswift
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specify a filename or directory name as the output-to setting in
SWIFT_BACKTRACE. If the option is set to a directory name, generate a unique filename in that directory using the process name, process ID and timestamp.rdar://136977833