Basic: query the target pointer width from clang #79223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
CC: @etcwilde |
DougGregor
reviewed
Feb 7, 2025
compnerd
force-pushed
the
sizeof-void-star
branch
from
248ecc1 to
03f19fb
Compare
|
@swift-ci please smoke test |
DougGregor
reviewed
Feb 7, 2025
compnerd
force-pushed
the
sizeof-void-star
branch
from
03f19fb to
9722e8f
Compare
DougGregor
approved these changes
Feb 7, 2025
|
@swift-ci please smoke test |
compnerd
force-pushed
the
sizeof-void-star
branch
from
9722e8f to
25d7540
Compare
|
@swift-ci please smoke test |
etcwilde
reviewed
Feb 10, 2025
Use the `clang::TargetInfo` to query the target pointer size for the given triple. This is meant to enable us to properly determine `CMAKE_SIZEOF_VOID_P`.
compnerd
force-pushed
the
sizeof-void-star
branch
from
25d7540 to
a04c75a
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
clang::TargetInfoto query the target pointer size for the given triple. This is meant to enable us to properly determineCMAKE_SIZEOF_VOID_P.