Skip to content

[Concurrency] Fix swift-inspect and remote mirror build #79715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

[Concurrency] Fix swift-inspect and remote mirror build #79715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/swift/RemoteInspection/ReflectionContext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ class ReflectionContext
bool IsFuture;
bool IsGroupChildTask;
bool IsAsyncLetTask;
bool IsSynchronousStartTask;

// Task flags.
unsigned MaxPriority;
Expand Down
1 change: 1 addition & 0 deletions include/swift/SwiftRemoteMirror/SwiftRemoteMirrorTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ typedef struct swift_async_task_info {
bool IsFuture;
bool IsGroupChildTask;
bool IsAsyncLetTask;
bool IsSynchronousStartTask;

unsigned MaxPriority;
bool IsCancelled;
Expand Down
1 change: 1 addition & 0 deletions stdlib/public/SwiftRemoteMirror/SwiftRemoteMirror.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,6 +1013,7 @@ swift_reflection_asyncTaskInfo(SwiftReflectionContextRef ContextRef,
Result.IsFuture = TaskInfo.IsFuture;
Result.IsGroupChildTask = TaskInfo.IsGroupChildTask;
Result.IsAsyncLetTask = TaskInfo.IsAsyncLetTask;
Result.IsSynchronousStartTask = TaskInfo.IsSynchronousStartTask;

Result.MaxPriority = TaskInfo.MaxPriority;
Result.IsCancelled = TaskInfo.IsCancelled;
Expand Down
2 changes: 0 additions & 2 deletions tools/swift-inspect/Sources/swift-inspect/Operations/DumpConcurrency.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ fileprivate class ConcurrencyDumper {
var isStatusRecordLocked: Bool
var isEscalated: Bool
var hasIsRunning: Bool
var isSynchronousStartTask: Bool
var isRunning: Bool
var isEnqueued: Bool
var threadPort: UInt32?
Expand Down Expand Up @@ -276,7 +275,6 @@ fileprivate class ConcurrencyDumper {
if info.isEscalated { flags.append("escalated") }
if info.hasIsRunning && info.isRunning { flags.append("running") }
if info.isEnqueued { flags.append("enqueued") }
if info.isSynchronousStart { flags.append("isSynchronousStartTask") }

let flagsStr = flags.isEmpty ? "0" : flags.joined(separator: "|")
return flagsStr
Expand Down