test: Improve test/Misc/verify-swift-feature-testing.test-sh
#79739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test macOS |
drodriguez
reviewed
Mar 3, 2025
There was a problem hiding this comment.
I think I was going for clarity with the multiple grep invocations over the same set of files, but if reducing the number of grep invocations brings the runtime to less than half, a little bit less clarity might be worth it.
I would like to know the reason for the new REQUIRES:. I work on Linux a lot, and this script can be helpful there too (and in Windows).
drodriguez
approved these changes
Mar 3, 2025
AnthonyLatsis
force-pushed
the
blin-blinskiy
branch
2 times, most recently
from
19a6c59 to
ccb205b
Compare
* The set of files that enable features and the set of files that require features are expected to have a very small, if any, difference. Don't compute and check each set separately. * Find RUN and REQUIRES lines in a file in one go.
* Account for variable number of spaces. * Match strings like '-enable-upcoming-feature\'. We want to complain about these because the script cannot get the job done when the option and argument are on different lines. The capture group will match '' in these cases.
* Place 'error: ' after file name. * Be more clear about what's wrong and where.
AnthonyLatsis
force-pushed
the
blin-blinskiy
branch
from
ccb205b to
02359f4
Compare
|
Thanks for the quick review! |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run it only on macOS.