[silgen] Place hop_to_executor emission for an apply within a formal evaluation scope. #79848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evaluation scope. Without this, the borrow of the hop_to_executor lasts after the apply. Beyond being unnecessary this results in an OSSA violation if we are passing an actor as an isolated parameter to an initializer since we hop_to_executor the actor and then pass it as a +1 parameter to the initializer causing the actor to be consumed before its borrow ends. rdar://144994837
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the borrow of the hop_to_executor lasts after the apply. Beyond being unnecessary this results in an OSSA violation if we are passing an actor as an isolated parameter to an initializer since we hop_to_executor the actor and then pass it as a +1 parameter to the initializer causing the actor to be consumed before its borrow ends.
rdar://144994837