Sema: Implement adoption mode for AsyncCallerExecution
#80008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
jckarter,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
ktoso,
hborla,
slavapestov and
xedin
as code owners
AnthonyLatsis
force-pushed
the
danaus-plexippus-4
branch
from
3811b07 to
969cdcd
Compare
|
@swift-ci please smoke test macOS |
ktoso
approved these changes
Mar 14, 2025
|
Looks good :) |
DougGregor
reviewed
Mar 14, 2025
|
|
||
| /// Add a fix-it suggesting to add the given attribute to the given | ||
| /// closure. | ||
| InFlightDiagnostic &fixItAddAttribute(const DeclAttribute *Attr, |
xedin
approved these changes
Mar 14, 2025
AnthonyLatsis
force-pushed
the
danaus-plexippus-4
branch
from
969cdcd to
cddb8c9
Compare
These files already have the appropriate Lit feature markers to prevent them from running with asserts if necessary.
Also combine the computed isolation and preconcurrency once at the end rather than at every return.
AnthonyLatsis
force-pushed
the
danaus-plexippus-4
branch
from
5c57899 to
1117b72
Compare
|
@swift-ci please smoke test |
AnthonyLatsis
force-pushed
the
danaus-plexippus-4
branch
from
1117b72 to
c499475
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In adoption mode, warn that the behavior of nonisolated async functions will change under
AsyncCallerExecutionand suggest@execution(concurrent)to preserve the current behavior.