Runtimes: properly link in swiftrtT?.obj on Windows
#80101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
etcwilde,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
etcwilde
requested changes
Mar 18, 2025
There was a problem hiding this comment.
I sense that this line will continue to grow and be a source of bugs as we try to keep everything in sync. Can we instead create an interface library (maybe SwiftRuntimeRegistration) that forwards the link of the appropriate swiftrt?
Then replace these with
...
swiftCore
SwiftRuntimeRegistration
...
|
@swift-ci please smoke test |
etcwilde
reviewed
Mar 19, 2025
etcwilde
reviewed
Mar 20, 2025
|
@swift-ci please smoke test |
`swiftrtT.obj` should be used for statically linking the standard library (or within the standard library itself). For the other modules, we need to differentiate between `swiftrt.obj` and `swiftrtT.obj`. This fixes that oversight. This was not caught by the CI builds as we do not currently build both the static and dynamic variants of the new runtimes.
|
@swift-ci please smoke test |
etcwilde
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftrtT.objshould be used for statically linking the standard library (or within the standard library itself). For the other modules, we need to differentiate betweenswiftrt.objandswiftrtT.obj. This fixes that oversight. This was not caught by the CI builds as we do not currently build both the static and dynamic variants of the new runtimes.