Always restore old env variables #80441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we invoke the script block it could throw an exception so we should wrap it in a try finally block to ensure that we can restore the old environment variables, otherwise you can end up back in a shell that has an incorrect set of variables set. This is most noticable if an exception is thrown when entering the vs dev shell since without resetting the old vars you will have invalid Visual Studio env variables set meaning you need to manually reset your shell environment.
|
cc @compnerd |
compnerd
approved these changes
Apr 7, 2025
|
@swift-ci please smoke test |
Co-authored-by: Saleem Abdulrasool <compnerd@compnerd.org>
auto-merge was automatically disabled
April 7, 2025 21:01
Head branch was pushed to by a user without write access
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we invoke the script block it could throw an exception so we should wrap it in a try finally block to ensure that we can restore the old environment variables, otherwise you can end up back in a shell that has an incorrect set of variables set.
This is most noticable if an exception is thrown when entering the vs dev shell since without resetting the old vars you will have invalid Visual Studio env variables set meaning you need to manually reset your shell environment.