Skip to content

[SymbolGraphGen] add Sendable to the allowed attributes in declaration fragments #80465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

[SymbolGraphGen] add Sendable to the allowed attributes in declaration fragments #80465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/SymbolGraphGen/SymbolGraph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ PrintOptions SymbolGraph::getDeclarationFragmentsPrintOptions() const {
ExcludeAttrs.erase("TypeAttrKind::NoEscape");
ExcludeAttrs.erase("TypeAttrKind::Escaping");
ExcludeAttrs.erase("TypeAttrKind::Inout");
ExcludeAttrs.erase("TypeAttrKind::Sendable");

// Don't allow the following decl attributes:
// These can be large and are already included elsewhere in
Expand Down
299 changes: 194 additions & 105 deletions test/SymbolGraph/Symbols/Mixins/DeclarationFragments/Full/Function.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,111 +1,200 @@
// RUN: %empty-directory(%t)
// RUN: %target-build-swift %s -module-name Function -emit-module -emit-module-path %t/
// RUN: %target-swift-symbolgraph-extract -module-name Function -I %t -pretty-print -output-dir %t
// RUN: %FileCheck %s --input-file %t/Function.symbols.json --match-full-lines --strict-whitespace
// RUN: %FileCheck %s --input-file %t/Function.symbols.json --match-full-lines --strict-whitespace --check-prefix=FOO
// RUN: %FileCheck %s --input-file %t/Function.symbols.json --match-full-lines --strict-whitespace --check-prefix=BAR

public func foo<S>(f: @escaping () -> (), ext int: Int = 2, s: S) where S: Sequence {}

// CHECK-LABEL:{{^ }}"declarationFragments": [
// CHECK: {
// CHECK-NEXT: "kind": "keyword",
// CHECK-NEXT: "spelling": "func"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": " "
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "identifier",
// CHECK-NEXT: "spelling": "foo"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": "<"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "genericParameter",
// CHECK-NEXT: "spelling": "S"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": ">("
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "externalParam",
// CHECK-NEXT: "spelling": "f"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": ": "
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "keyword",
// CHECK-NEXT: "spelling": "@escaping"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": " () -> (), "
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "externalParam",
// CHECK-NEXT: "spelling": "ext"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": " "
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "internalParam",
// CHECK-NEXT: "spelling": "int"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": ": "
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "typeIdentifier",
// CHECK-NEXT: "spelling": "Int",
// CHECK-NEXT: "preciseIdentifier": "s:Si"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": " = 2, "
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "externalParam",
// CHECK-NEXT: "spelling": "s"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": ": "
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "typeIdentifier",
// CHECK-NEXT: "spelling": "S"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": ") "
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "keyword",
// CHECK-NEXT: "spelling": "where"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": " "
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "typeIdentifier",
// CHECK-NEXT: "spelling": "S"
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "text",
// CHECK-NEXT: "spelling": " : "
// CHECK-NEXT: },
// CHECK-NEXT: {
// CHECK-NEXT: "kind": "typeIdentifier",
// CHECK-NEXT: "spelling": "Sequence",
// CHECK-NEXT: "preciseIdentifier": "s:ST"
// CHECK-NEXT: }
// CHECK-NEXT: ],
// FOO-LABEL: "precise": "s:8Function3foo1f3ext1syyyc_SixtSTRzlF",
// FOO:{{^ }}"declarationFragments": [
// FOO-NEXT: {
// FOO-NEXT: "kind": "keyword",
// FOO-NEXT: "spelling": "func"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": " "
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "identifier",
// FOO-NEXT: "spelling": "foo"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": "<"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "genericParameter",
// FOO-NEXT: "spelling": "S"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": ">("
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "externalParam",
// FOO-NEXT: "spelling": "f"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": ": "
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "keyword",
// FOO-NEXT: "spelling": "@escaping"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": " () -> (), "
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "externalParam",
// FOO-NEXT: "spelling": "ext"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": " "
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "internalParam",
// FOO-NEXT: "spelling": "int"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": ": "
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "typeIdentifier",
// FOO-NEXT: "spelling": "Int",
// FOO-NEXT: "preciseIdentifier": "s:Si"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": " = 2, "
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "externalParam",
// FOO-NEXT: "spelling": "s"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": ": "
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "typeIdentifier",
// FOO-NEXT: "spelling": "S"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": ") "
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "keyword",
// FOO-NEXT: "spelling": "where"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": " "
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "typeIdentifier",
// FOO-NEXT: "spelling": "S"
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "text",
// FOO-NEXT: "spelling": " : "
// FOO-NEXT: },
// FOO-NEXT: {
// FOO-NEXT: "kind": "typeIdentifier",
// FOO-NEXT: "spelling": "Sequence",
// FOO-NEXT: "preciseIdentifier": "s:ST"
// FOO-NEXT: }
// FOO-NEXT: ],

public func bar<T>(_ apply: () -> T, onChange: @autoclosure () -> @Sendable () -> Void) {}

// BAR-LABEL: "precise": "s:8Function3bar_8onChangeyxyXE_yyYbcyXKtlF",
// BAR: "declarationFragments": [
// BAR-NEXT: {
// BAR-NEXT: "kind": "keyword",
// BAR-NEXT: "spelling": "func"
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "text",
// BAR-NEXT: "spelling": " "
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "identifier",
// BAR-NEXT: "spelling": "bar"
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "text",
// BAR-NEXT: "spelling": "<"
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "genericParameter",
// BAR-NEXT: "spelling": "T"
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "text",
// BAR-NEXT: "spelling": ">("
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "externalParam",
// BAR-NEXT: "spelling": "_"
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "text",
// BAR-NEXT: "spelling": " "
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "internalParam",
// BAR-NEXT: "spelling": "apply"
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "text",
// BAR-NEXT: "spelling": ": () -> "
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "typeIdentifier",
// BAR-NEXT: "spelling": "T"
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "text",
// BAR-NEXT: "spelling": ", "
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "externalParam",
// BAR-NEXT: "spelling": "onChange"
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "text",
// BAR-NEXT: "spelling": ": "
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "attribute",
// BAR-NEXT: "spelling": "@autoclosure "
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "text",
// BAR-NEXT: "spelling": "() -> "
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "attribute",
// BAR-NEXT: "spelling": "@Sendable"
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "text",
// BAR-NEXT: "spelling": " () -> "
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "typeIdentifier",
// BAR-NEXT: "spelling": "Void",
// BAR-NEXT: "preciseIdentifier": "s:s4Voida"
// BAR-NEXT: },
// BAR-NEXT: {
// BAR-NEXT: "kind": "text",
// BAR-NEXT: "spelling": ")"
// BAR-NEXT: }
// BAR-NEXT: ],