Skip to content

Conversation

hamishknight
Copy link
Contributor

6.2 cherry-pick of #80546

  • Explanation: Fixes a crash that could occur when using an attached macro in a local context that contains a use of an autoclosure
  • Scope: Affects attached macros in local contexts
  • Issue: rdar://143834482
  • Risk: Low, this a straightforward targeted fix
  • Testing: Added tests to test suite
  • Reviewer: Doug Gregor

If we're using the macro-specific local discriminator, we need to
make sure we avoid mangling the regular local discriminator in
`appendDeclName`, since that could prematurely kick local discriminator
assignment before type-checking has finished.

rdar://143834482
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Apr 7, 2025
@hamishknight hamishknight requested a review from bnbarham April 7, 2025 09:31
@hamishknight hamishknight requested a review from a team as a code owner April 7, 2025 09:31
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit 362a239 into swiftlang:release/6.2 Apr 7, 2025
5 checks passed
@hamishknight hamishknight deleted the mangle-less-6.2 branch April 7, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants