[6.2][cxx-interop] Fix calling rvalue ref of a trivial type #80584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation: Fixes a runtime crash in the generated binary due to mismatched calling convention when calling a function taking an rvalue reference. Scope: Affects C++ APIs taking rvalue references to directly passed types (e.g., trivially destructible types). Issue: rdar://148585343 Risk: Low, targeted to rvalue references which is a newly supported feature. Testing: Added tests to test suite Reviewer: John Hui
Xazax-hun
added
c++ interop
egorzhdan
approved these changes
Apr 7, 2025
|
@swift-ci please test |
airspeedswift
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a runtime crash in the generated binary due to mismatched calling convention when calling a function taking an rvalue reference.
Scope: Affects C++ APIs taking rvalue references to directly passed types (e.g., trivially destructible types).
Issue: rdar://148585343
Risk: Low, targeted to rvalue references which is a newly supported feature.
Testing: Added tests to test suite
Reviewer: @j-hui